feat!: don't read strict from tsconfig.json
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsconfig's definition of strict is different to swc's, so we shouldn't treat them as the same field. Default swc strict mode to false. It can still be overridden by manual config if required. Fixes songkeys#10.
Closed
songkeys
reviewed
Jun 13, 2022
'false' is currently the default, but we want the default behaviour from swc so will leave it unset. Fixes songkeys#10.
|
Thank you so much! I'll publish v2.0.0 as it's a breaking change. |
songkeys
changed the title
strict from tsconfig.json
|
Thanks for your quick review and merge @songkeys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsconfig's definition of strict is different to swc's, so we shouldn't treat them as the same field.
Default swc strict mode to false. It can still be overridden by manual config if required.
Fixes #10.